test: construct multisig_tests inputs/outputs declaratively #36750

pull yuvicc wants to merge 1 commits into bitcoin:master from yuvicc:test-multisig-declarative changing 1 files +24 −20
  1. yuvicc commented at 6:00 AM on November 4, 2026: contributor

    Part of #36692. This replaces the field-by-field construction of transaction inputs and outputs in multisig_tests with COutPoint, CTxIn and CTxOut constructor calls.

    It keeps CMutableTransaction as the builder, since a CTransaction constructor taking inputs and outputs directly is still under discussion (#36696). If one is added, the vin/vout lists here can be passed to it directly.

    This change is test-only and does not change the constructed transactions:

    • The funding outputs were previously created by vout.resize(3) and only had their scriptPubKey assigned, leaving nValue at its null value (-1). The -1 is now spelled out explicitly, which makes this previously hidden value visible
    • The loop index is changed from int to uint32_t to match COutPoint::n
  2. test: construct multisig_tests inputs/outputs declaratively
    Replace the field-by-field construction of the inputs and outputs in
    multisig_verify and multisig_Sign with COutPoint, CTxIn and CTxOut
    constructor calls.
    
    The funding outputs were previously created by vout.resize(3) and only
    had their scriptPubKey assigned, leaving nValue null (-1). The -1 is
    now spelled out explicitly so the transactions are unchanged.
    
    The loop index is changed to uint32_t to match COutPoint::n, as
    brace-initialization does not allow the narrowing conversion from int.
    c723c37de6
  3. DrahtBot added the label Tests on Nov 4, 2026
  4. DrahtBot commented at 6:00 AM on November 4, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK alexanderwiederin, purpleKarrot, maflcko

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. yuvicc closed this on Nov 4, 2026

  6. yuvicc reopened this on Nov 4, 2026

  7. fanquake requested review from alexanderwiederin on Nov 4, 2026
  8. alexanderwiederin approved
  9. alexanderwiederin commented at 9:13 AM on November 5, 2026: contributor

    ACK c723c37

    Checked that the constructed transactions are unchanged by printing their structure (prevout indices, nSequence, output values and script sizes) before and after.

    Thanks! If you open more of these, feel free to bundle a few files per PR.

  10. purpleKarrot commented at 9:35 AM on November 5, 2026: contributor

    @yuvicc, thanks for joining the #36692 movement!

    ACK c723c37

  11. maflcko commented at 9:56 AM on November 5, 2026: member

    review ACK c723c37de69fd95e6ec795e848efb03d944999ba 🍯

    <details><summary>Show signature</summary>

    Signature:

    untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    trusted comment: review ACK c723c37de69fd95e6ec795e848efb03d944999ba 🍯
    iRs97BB6MXUp37+CXvxQw/B8LhttTKjIstoBw0S2KJ/7CA3GN1XHeL/FTaqi2s9mDyyukob3LjI40scikWm+BQ==
    

    </details>

  12. fanquake merged this on Nov 5, 2026
  13. fanquake closed this on Nov 5, 2026

  14. yuvicc deleted the branch on Nov 5, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-18 16:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me