build: CMake `-Werror=dev` option is deprecated #36780

According to CI output, -Werror=dev is now deprecated. https://github.com/bitcoin/bitcoin/actions/runs/42034315042/job/127268360482#step:9:519:

cmake -S /Users/runner/work/bitcoin/bitcoin/repo_archive -B '/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch_ ₿🧪/build-aarch64-apple-darwin24.6.0' -DCMAKE_COMPILE_WARNING_AS_ERROR=ON '-DCMAKE_INSTALL_PREFIX=/Users/runner/work/bitcoin/bitcoin/repo_archive/ci/scratch ₿🧪_/out' -Werror=dev -DBUILD_FOR_FUZZING=ON '-DCMAKE_EXE_LINKER_FLAGS=-Wl,-stack_size -Wl,0x80000' -DAPPEND_CPPFLAGS=-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_DEBUG

The error=dev option is deprecated. Use -Werror=author instead.

This was only added in cmake 4.4 (https://cmake.org/cmake/help/latest/diagnostic/CMD_AUTHOR.html)? So it seems fine and harmless to ignore for a few years until cmake 5?

it's a straightforward fix to the CI scripts and tests. no harm in updating now considering possible confusion to new Bitcoin Core users who may be unfamiliar with the CMake tool

Hi @fanquake! I'd like to pick this up — could I be assigned? I have understood the issue, and here is my approach:

• -Werror=dev is used in ci/test/03_test_script.sh, .github/ci-windows.py, .github/ci-test-each-commit-exec.py and the guix build scripts
• A plain swap isn't safe: on CMake 3.28, -Werror=author is accepted but silently ignored (an AUTHOR_WARNING doesn't fail), so the check would be lost below CMake 4.4
• Fix: choose the flag by CMake version in the CI scripts (-Werror=author on ≥ 4.4, -Werror=dev otherwise)
• Leave the guix scripts unless their pinned CMake is ≥ 4.4