Increase default dbcache to 100 MiB #3680

pull sipa wants to merge 1 commits into bitcoin:master from sipa:moarcache changing 2 files +3 −3

sipa commented at 2:54 PM on February 16, 2014: member

25 MiB is really silly small compared to the rest of the memory requirements, and slows down initial sync.
int03h commented at 3:51 PM on February 16, 2014: none

Agreed !!
jgarzik commented at 3:54 PM on February 16, 2014: contributor

Any before/after numbers? Any quantification?
int03h commented at 4:05 PM on February 16, 2014: none

With Armory it reduces DB scan / load times significantly. From an hour or 2 to around 15-20 minutes or so on Windoze. (to be fair .. I use 2000MB instead of 25MB or even 100MB) .. it also seems to speed up initial load times a lot.
ghost commented at 4:09 PM on February 16, 2014: none

Could this become a startup option/config file option?
int03h commented at 4:24 PM on February 16, 2014: none

dbcache=100 in your bitcoin.conf will achieve this.
Diapolo commented at 5:07 PM on February 16, 2014: none

@sipa You need to take care of the GUI defaults also... @drak Also with 0.9 that option was added to the GUI options.
laanwj commented at 5:18 PM on February 16, 2014: member

ACK on the default change. @Diapolo It's more helpful to point at the line that needs to be updated: https://github.com/bitcoin/bitcoin/blob/master/src/qt/optionsmodel.cpp#L87

It may make sense to define a constant instead of updating to a new magic number in all three places (GetArg, help function, GUI).
Increase default dbcache to 100 MiB a8d45d6cfc
sipa commented at 7:56 PM on February 16, 2014: member

Updated.
BitcoinPullTester commented at 8:38 PM on February 16, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a8d45d6cfc545827b159e14dbe47ac41dd1b2f30 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 8:46 PM on February 16, 2014: none

ACK, I intend to create a constant for these settings, that are shared by GUI and core.
Diapolo commented at 9:02 PM on February 16, 2014: none

See #3687
Eveiv commented at 4:44 AM on February 17, 2014: none

@jgarzik I can't speak with exact numbers, but the increase in sync speed is tangible.
gavinandresen commented at 5:10 PM on February 17, 2014: contributor

ACK
jgarzik commented at 5:38 PM on February 17, 2014: contributor

ACK

Would be nice if all '100' magic numbers had an associated named constant.
sipa commented at 5:44 PM on February 17, 2014: member

@jgarzik #3687
laanwj commented at 5:46 PM on February 17, 2014: member

Yes let's merge #3687 instead
laanwj closed this on Feb 17, 2014
DrahtBot locked this on Sep 8, 2021

Contributors