add constant for shared (GUI/core) setting -dbcache #3687

pull Diapolo wants to merge 2 commits into bitcoin:master from Diapolo:dbcache changing 5 files +20 −18

Diapolo commented at 9:01 PM on February 16, 2014: none
- adds nDefaultDbCache, nMaxDbCache and nMinDbCache in txdb.h
sipa commented at 9:09 PM on February 16, 2014: member

ACK, if pulltester is happy.
wtogami commented at 6:49 AM on February 17, 2014: contributor

ACK
laanwj commented at 7:32 AM on February 17, 2014: member

ACK
Increase default dbcache to 100 MiB 879b390758

in src/init.cpp:None in 6a2650a942 outdated

 771 | @@ -772,9 +772,11 @@ bool AppInit2(boost::thread_group& threadGroup)
 772 |      }
 773 |  
 774 |      // cache size calculations
 775 | -    size_t nTotalCache = GetArg("-dbcache", 25) << 20;
 776 | +    size_t nTotalCache = GetArg("-dbcache", nDefaultDbCache) << 20;
 777 |      if (nTotalCache < (1 << 22))

laanwj commented at 8:08 AM on February 17, 2014:

We could make this nMinDbCache and use it in the GUI as well. AFAIK there is currently no lower bound there.

Diapolo commented at 2:21 PM on February 17, 2014: none

I added nMinDbCache and also use it for the GUI now.
Diapolo commented at 2:25 PM on February 17, 2014: none

@laanwj Have you got a nice and clean idea, how we could share strprintf(_("Set database cache size in megabytes (%d to %d, default: %d)"), nMinDbCache, nMaxDbCache, nDefaultDbCache) with the Qt settings tooltip (which is currently wrong, as I didn't yet update it)?
laanwj commented at 2:28 PM on February 17, 2014: member

@Diapolo IMO the default, min and max do not need to be in the tooltip at all, it should just explain what the setting does. We don't need that in the GUI: the limits are enforced by the widget, and the default is already shown by default :)
add constants for shared (GUI/core) -dbcache settings
- adds nDefaultDbCache, nMaxDbCache and nMinDbCache in txdb.h
82e96006ae
Diapolo commented at 2:45 PM on February 17, 2014: none

I removed the tooltip and unneeded defaults from the .ui file but left the min and max in the description, for par we also have such extended infos for example :).
BitcoinPullTester commented at 3:49 PM on February 17, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/82e96006ae03a7debebb9ad36f939ddabb0d2f9f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
jgarzik commented at 5:50 PM on February 17, 2014: contributor

ACK
laanwj referenced this in commit bd8e3751d7 on Feb 18, 2014
laanwj merged this on Feb 18, 2014
laanwj closed this on Feb 18, 2014
Diapolo deleted the branch on Feb 18, 2014
DrahtBot locked this on Sep 8, 2021

Contributors