refactor: Introduce `node/node_id.h` header and fix includes in related modules #36807

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:261108-nodeid changing 10 files +59 −20
  1. hebasto commented at 6:57 PM on November 8, 2026: member

    Two identical declarations of NodeId make it ambiguous for static tools such as IWYU which header should provide the symbol. The first commit moves the declaration into a header of its own.

    The second commit fixes the #includes of the net and node/eviction modules, which the first commit touched, and adds the headers that other files previously received transitively from them.

    A prerequisite for #36808.

  2. refactor: Introduce `node/node_id.h` header
    Two identical declarations of `NodeId` make it ambiguous for static
    tools such as IWYU which header should provide the symbol. Move the
    declaration into a header of its own.
    
    `net.h` re-exports it, since `NodeId` is part of its interface.
    685dbef600
  3. refactor: Fix `#include`s in `net` and `node/eviction` modules
    The `#include`s added to other files replace ones they previously
    received transitively via `net.h` and `node/eviction.h`.
    144b4abf6a
  4. DrahtBot added the label Refactoring on Nov 8, 2026
  5. DrahtBot commented at 6:58 PM on November 8, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK jpk68

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  6. hebasto removed the label Refactoring on Nov 8, 2026
  7. DrahtBot added the label Refactoring on Nov 8, 2026
  8. jpk68 commented at 7:27 PM on November 8, 2026: contributor

    ACK 144b4abf6a877d0ddab54fef823b4119aede7969

  9. DrahtBot added the label CI failed on Nov 8, 2026
  10. DrahtBot removed the label CI failed on Nov 8, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-09 21:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me