refactor: remove more dead code #36820
pull fanquake wants to merge 22 commits into bitcoin:master from fanquake:some_more_removals changing 27 files +15 −124-
fanquake commented at 6:41 PM on November 9, 2026: member
-
descriptor: remove unused ctx parameter from InferXOnlyPubkey b851f55e59
-
989b62c34f
fees: remove unused FeeCalculation::best_height
It is written but never read.
-
serialize: remove unused GetSizeOfVarInt 1c5b36bf1e
-
ui: remove unused CClientUIInterface::ICON_MASK ff3585fe31
-
util: remove unused TokenBucket clock and duration aliases 5d80156f4e
-
70648fa318
util: remove unused util::insert overloads
The only caller, in wallet/coinselection.h, inserts into a std::set with a custom comparator, so only the std::set<TsetT, Compare> overload is ever selected.
-
serialize: remove unused unique_ptr<const T> serialization fbdc16ff07
-
policy: remove unused STANDARD_NOT_MANDATORY_VERIFY_FLAGS 37c4df1130
-
rpc: remove write-only input_txos from scantxoutset 30a8a87280
-
wallet: remove unused CoinsResult::TypesCount 45620064a1
-
bitcoin-chainstate: remove unused m_expected_valid_block 21515e4a32
-
bitcoind: remove unused std::any context in AppInit a8887ced68
-
bench: remove unused accumulator in MuHashPrecompute 9b577fa6df
-
test: remove unused block copies in TestBasicMining ca448eeb40
-
test: remove unused CMutableTransaction in orphanage peer_dos_limits 321915a33a
-
ui: remove unused CClientUIInterface::SECURE flag 625c97f6b5
-
rest: remove no-op InterruptREST 8ed5de2f4e
-
torcontrol: remove commented-out cookie AUTHENTICATE command 8765595f45
-
net: remove unused const CConnman::ForEachNode overload 9742479ef5
-
qt: remove unused RPCConsole::cachedNodeids 67f9ff8320
-
wallet: remove unused last_client parameter from LoadLegacyWalletRecords f8b10695bd
-
qt: remove unused couldSignInputs psbtx parameter 5935ae60a8
- DrahtBot added the label Refactoring on Nov 9, 2026
-
DrahtBot commented at 6:41 PM on November 9, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36820
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36820.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36820#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Labels