test: add coverage for joinpsbts with fewer than two PSBTs #36851

pull Pranav-error wants to merge 1 commits into bitcoin:master from Pranav-error:test-joinpsbts-min-count changing 1 files +5 −1

Pranav-error commented at 7:29 AM on November 13, 2026: none

Added a couple of test cases for joinpsbts to cover empty and single PSBT inputs.

The existing tests only covered cases with two or more PSBTs, so these tests make sure the minimum input requirement is handled correctly.

test: add coverage for joinpsbts with fewer than two PSBTs

Added tests for joinpsbts with empty and single PSBT inputs to make sure both return the expected error.

701f48ad46

DrahtBot added the label Tests on Nov 13, 2026
DrahtBot commented at 7:29 AM on November 13, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36851
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36851.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36851#author-ralph


Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK nebula-21, mercie-ux

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Type	Reviewers
ACK	nebula-21, mercie-ux

in test/functional/rpc_psbt.py:1404 in 701f48ad46

1399 | @@ -1400,8 +1400,12 @@ def test_psbt_input_keys(psbt_input, keys):
1400 |          test_psbt_input_keys(decoded['inputs'][1], psbt_v2_required_keys + ['non_witness_utxo', 'bip32_derivs'])
1401 |          test_psbt_input_keys(decoded['inputs'][2], psbt_v2_required_keys + ['non_witness_utxo', 'witness_utxo', 'bip32_derivs', 'redeem_script'])
1402 |  
1403 | -        # Cannot join PSBTv2s
1404 | +        # joinpsbts requires at least two PSBTs
1405 |          psbt1 = self.nodes[1].createpsbt(inputs=[utxo1], outputs={self.nodes[0].getnewaddress():Decimal('10.999')}, psbt_version=0)

nebula-21 commented at 11:49 AM on November 13, 2026:

Feel free to ignore this nit, but I would create psbt1 after checking that empty joinpsbts fails.

       assert_raises_rpc_error(-8, "At least two PSBTs are required to join PSBTs", self.nodes[1].joinpsbts, [])
        psbt1 = self.nodes[1].createpsbt(inputs=[utxo1], outputs={self.nodes[0].getnewaddress():Decimal('10.999')}, psbt_version=0)

nebula-21 commented at 11:51 AM on November 13, 2026: contributor

ACK 701f48ad463bee92706d493940b0df4f77461426
mercie-ux commented at 9:07 AM on November 14, 2026: contributor

ACK 701f48a

Contributors

Labels

test: add coverage for joinpsbts with fewer than two PSBTs #36851

External sites

Reviews