CreateNewBlock_validity mines a 110-block chain and then runs four subtests on it as member functions. The subtests share one chain, so each starts from whatever the previous one left behind, and the caller has to patch Tip()->nHeight between them. Inside TestBasicMining a single CMutableTransaction is reused across all sections, with each section overwriting some of its fields, so the transaction a section actually tests depends on every section before it.
This PR removes both kinds of hidden state.