test: remove legacy wallet leftovers from wallet functional tests #36867

pull w0xlt wants to merge 3 commits into bitcoin:master from w0xlt:test-wallet-legacy-leftovers changing 3 files +40 −92
  1. w0xlt commented at 6:35 AM on November 14, 2026: contributor

    This PR cleans up three tests that still carry code or text from the legacy wallet:

    • wallet_address_types.py: the send loop iterates over do_multisigs = [False], so its multisig code path and the multisig cases of test_address/test_desc can't run. That code path is also broken, since it never sets the address it checks. This PR removes that code, along with the docstring section about the old addmultisigaddress tests.

    • wallet_backup.py: the docstring still describes dumpwallet/importwallet and erasing wallets; the test uses backupwallet and restorewallet.

    • wallet_hd.py: -keypool=0 does nothing for descriptor wallets, which always keep at least one key, and the test config already sets keypool=1.

    No coverage changes: wallet_address_types.py runs the same 8 send iterations before and after.

  2. DrahtBot added the label Tests on Nov 14, 2026
  3. DrahtBot commented at 6:35 AM on November 14, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK adezo24h1

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #36257 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36257.svg"></sub> (qa: assert_equals -> assert_true/assert_false by hodlinator)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. adezo24h1 commented at 2:32 PM on November 16, 2026: none

    tACK 95cb680e422feb36c4ffe406b5a91b9db76307da Ran on Ubuntu 24.04 WSL: python3 build/test/functional/test_runner.py wallet_address_types.py wallet_backup.py wallet_hd.py Result: pass

  5. test: remove dead multisig code from wallet_address_types
    The send loop runs over do_multisigs = [False], so multisig is always
    false. True was only added for legacy wallets (59d3da5bce), and that
    was removed together with the legacy wallet tests in c847dee148.
    
    Remove the multisig loop dimension, the unreachable multisig code path,
    which has not set the address it then checks since fe838dd391, and the
    multisig cases of test_address and test_desc. Also drop the docstring
    section about the removed addmultisigaddress tests, correct the senders
    to node0-node3, and fix the "N/101th" fractions in the same list.
    363355a72d
  6. test: update wallet_backup docstring
    The docstring still describes backing up with dumpwallet, erasing the
    wallets and restoring with importwallet. The test now backs up with
    backupwallet and restores the backups on the miner with restorewallet.
    1ac0e9cd5b
  7. test: remove no-op -keypool=0 from wallet_hd
    Descriptor wallets always keep a keypool of at least 1, and the
    functional test configuration already sets keypool=1, so -keypool=0
    does not change anything for node1.
    b9b33544aa
  8. w0xlt force-pushed on Nov 16, 2026
  9. w0xlt commented at 8:55 PM on November 16, 2026: contributor

    Thanks @adezo24h1 . Pushed a new version to fix the pre-existing N/101th typos flagged by the LLM linter (docstring only).

  10. adezo24h1 commented at 10:52 PM on November 16, 2026: none

    tACK b9b33544aaf17d47d27f7393d3e21d6ff8f93485

Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-18 16:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me