test: construct `coinselection_tests` output declaratively #36888

pull yuvicc wants to merge 1 commits into bitcoin:master from yuvicc:test-declarative-coinselection-tests changing 1 files +4 −3
  1. yuvicc commented at 12:03 PM on November 16, 2026: contributor

    Part of #36692:

    Build the funding output in MakeCoin() from coinselection_tests with a CTxOut constructor instead of vout.resize(1) followed by assigning nValue. Test-only change, the constructed txns are unchanged and the empty scriptPubKey that resize() left implicit is now explicit.

  2. test: construct coinselection_tests output declaratively
    Build the transaction output in MakeCoin with a CTxOut
    constructor instead of resizing vout and assigning nValue afterwards.
    
    The resulting transaction is unchanged.
    77476af7be
  3. DrahtBot added the label Tests on Nov 16, 2026
  4. DrahtBot commented at 12:03 PM on November 16, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK alexanderwiederin

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. alexanderwiederin approved
  6. alexanderwiederin commented at 9:37 AM on November 18, 2026: contributor

    ACK 77476af7be7ad2a9a1abf4e0a82cb7dbcce2fb5f

    The output is identical to before: resize(1) left the scriptPubKey empty, which CScript{} now makes explicit.

    Built and ran coinselection_tests.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-18 16:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me