Fail to load wallet if it contains unknown keys. #378

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:encprep changing 4 files +29 −9

TheBlueMatt commented at 12:28 PM on July 4, 2011: member

The motivation here is that if a wallet is encrypted, old versions should simply fail to load the wallet. Additionally, if a wallet gets corrupted, the client should always fail to load the wallet to give the user a chance for manual recovery.

This needs to go into 0.3.24, so that users who downgrade don't mess up their wallet by adding unencrypted keys to an encrypted wallet, making all versions unable to use the wallet.
TheBlueMatt commented at 12:41 PM on July 4, 2011: member

Just to clear up the motivation here: why should bitcoin not refuse to load wallets that appear incompatible?

Fail to load wallet if it contains unknown keys.

The motivation here is that if a wallet is encrypted, old versions
should simply fail to load the wallet.  Additionally, if a wallet
gets corrupted, the client should always fail to load the wallet
to give the user a chance for manual recovery.

b67a60eb68

TheBlueMatt commented at 12:17 PM on July 13, 2011: member

Superseded.
TheBlueMatt closed this on Jul 13, 2011
laanwj referenced this in commit 0ffb3bd95f on Aug 4, 2016
laanwj referenced this in commit b2135359b3 on Aug 16, 2016
MarcoFalke referenced this in commit 64dfdde0aa on Dec 13, 2016
deadalnix referenced this in commit 0b3e618a1c on Jan 19, 2017
rajarshimaitra referenced this in commit 7bced58597 on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

TheBlueMatt

Linked (view graph)

#381 Add minversion to wallet.