Clarify the message when unable to bind port #3798

pull paveljanik wants to merge 2 commits into bitcoin:master from paveljanik:patch-1 changing 1 files +2 −2
  1. paveljanik commented at 11:03 PM on March 4, 2014: contributor

    When bitcoind can't bind, bitcoin server (or Bitcoin Core Daemon) is probably already running. Add the missing word "server". Bitcoin itself is definitely running ;-)

    Add _(...) so the string can be localized.

    I apologize for such trivial changes, learning github interface (if I'm doing something wrong, please tell me so, thank you).

  2. Bitcoin is running fine...
    When bitcoind can't bind, bitcoin server (or Bitcoin Core Daemon) is probably already running. Add the missing word "server". Bitcoin itself is definitely running ;-)
    
    Add _(...) so the string can be localized.
    
    I apologize for such trivial changes, learning github interface.
    094eeff0ba
  3. laanwj commented at 9:02 AM on March 5, 2014: member

    Can you make the commit message a bit more informative? (something like: clarify message when unable to bind port)

    No need to apologize for trivial changes, making help and error messages more clear is worth it and, unlike other code changes, easy to review.

  4. Clarify the error message when unable to bind to port 2d2d8fae3d
  5. laanwj commented at 10:25 AM on March 5, 2014: member

    ACK

  6. BitcoinPullTester commented at 10:31 AM on March 5, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2d2d8fae3d8bc4e82dc631d93c6e19f954bbee04 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  7. laanwj referenced this in commit 334bd22e75 on Mar 5, 2014
  8. laanwj merged this on Mar 5, 2014
  9. laanwj closed this on Mar 5, 2014

  10. laanwj commented at 10:54 AM on March 5, 2014: member

    Next time please squash commits into one, for example using git rebase -i. (if you have multiple small changes, submitting them as separate commits makes no sense)

  11. paveljanik commented at 10:58 AM on March 5, 2014: contributor

    Thanks, will try to do. I'm trying to use only github web UI to learn its possibilities...

  12. paveljanik deleted the branch on Mar 5, 2014
  13. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me