Slightly tweak error when unable to bind port #3806

pull Michagogo wants to merge 2 commits into bitcoin:master from Michagogo:patch-1 changing 2 files +2 −2
  1. Michagogo commented at 4:25 PM on March 5, 2014: contributor

    A slight improvement over 2d2d8fae3d8bc4e82dc631d93c6e19f954bbee04 (#3798) -- we shouldn't assume that it's the daemon, it could be the GUI.

  2. Slightly tweak error when unable to bind port
    A slight improvement over 2d2d8fae3d8bc4e82dc631d93c6e19f954bbee04 -- we don't know that it's the daemon, it could be the GUI.
    d30d379beb
  3. laanwj commented at 4:38 PM on March 5, 2014: member

    Agree that this is an improvement, but do we really need zillions of pulls for this...

  4. Michagogo commented at 4:40 PM on March 5, 2014: contributor

    @laanwj No, but I think that that particular change was not a good one. The way it was is fine, this is better, but IMHO that change was a negative one.

  5. Adjust branding in datadir lock error message 9e2872c234
  6. Michagogo commented at 8:16 PM on March 12, 2014: contributor

    Added another commit to make a similar change to the init.cpp message for failure to lock data directory, after it was pointed out to me in IRC that the port message is far less common than the datadir one for normal, day-to-day users that might be confused by the change.

  7. BitcoinPullTester commented at 10:17 PM on March 18, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9e2872c234d9b4fc7ae2b69326fe9610f7b18264 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  8. laanwj referenced this in commit fc5d85c4bb on Mar 21, 2014
  9. laanwj merged this on Mar 21, 2014
  10. laanwj closed this on Mar 21, 2014

  11. Michagogo deleted the branch on Dec 11, 2014
  12. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me