Test CHECKMULTISIG with m == 0 and/or n == 0 #3860
pull petertodd wants to merge 2 commits into bitcoin:master from petertodd:test-checkmulti-n-m-zero changing 3 files +107 −1-
petertodd commented at 1:42 am on March 13, 2014: contributorTurns out that’s valid, and we don’t test it.
-
Fix script test handling of empty scripts
Previously an empty script would evaluate to OP_0
-
Test CHECKMULTISIG with m == 0 and n == 0 d3a33fc869
-
laanwj commented at 10:16 am on March 13, 2014: memberACK
-
BitcoinPullTester commented at 9:14 pm on March 18, 2014: noneAutomatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d3a33fc869d23fb13c010a6e9995bdf6574a621e for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
petertodd commented at 5:13 am on May 7, 2014: contributorCan we get this merged? Writing more tests and it’s annoying not having this in master.
-
laanwj added this to the milestone 0.9.2 on May 7, 2014
-
laanwj commented at 5:57 am on May 7, 2014: memberWell, it looks fine to me, just a bit surprised that no one else has reviewed it in all that time. @thebluematt @mikehearn as this test data is used by BitcoinJ as well, can you have a look here?
-
petertodd commented at 7:10 am on May 7, 2014: contributorYeah, tests aren’t sexy. Used in python-bitcoinlib too now.
-
sipa commented at 10:56 am on May 7, 2014: memberUntested ACK
-
mikehearn commented at 12:17 pm on May 9, 2014: contributor
Sorry, I didn’t review it because I didn’t know about it. At-mentioning me to get a review is definitely the right thing to do!
The code looks fine and I took the json files and ran them through bitcoinj, and they passed. So it all LGTM. Please merge.
-
gavinandresen referenced this in commit aaab675a78 on May 9, 2014
-
gavinandresen merged this on May 9, 2014
-
gavinandresen closed this on May 9, 2014
-
markblundeberg referenced this in commit 78bd3d936e on Jun 7, 2019
-
jtoomim referenced this in commit 5a27b8cccd on Jun 29, 2019
-
jonspock referenced this in commit b1ea011d92 on Jul 4, 2019
-
jonspock referenced this in commit 2c1056d027 on Jul 4, 2019
-
proteanx referenced this in commit 4d52f0671d on Jul 5, 2019
-
jonspock referenced this in commit 0b4a16fa7a on Jul 9, 2019
-
dagurval referenced this in commit 6d63b455a3 on Aug 31, 2019
-
sickpig referenced this in commit 47ef86232a on Sep 4, 2019
-
sickpig referenced this in commit c76b8caca6 on Sep 5, 2019
-
dagurval referenced this in commit 4656b09933 on Sep 6, 2019
-
DrahtBot locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 18:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me