Minor change, just updating copyright disclaimer from 2013 to 2014.
Updating year of Copyright disclaimer from 2013 to 2014. #3944
pull felipelalli wants to merge 1 commits into bitcoin:master from felipelalli:master-copyright-update changing 130 files +130 −130-
felipelalli commented at 7:17 AM on March 23, 2014: none
-
Updating year of Copyright disclaimer from 2013 to 2014. 17a326b88c
-
BitcoinPullTester commented at 7:39 AM on March 23, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/17a326b88cb2d117fbc82c2aa107b328119a59a2 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 8:11 AM on March 23, 2014: member
Indeed. Only update copyright headers when something in the code changed in that year.
Note that the copyright headers in src/test and qa/ were added recently, so the adding of those headers doesn't count towards the year either.
-
felipelalli commented at 9:32 AM on March 23, 2014: none
Thank you for the explanation, I'm sorry for the mistake.
-
leofidus commented at 3:47 PM on March 23, 2014: none
It's also unnessesary to write "Copyright (c)" since the (c) is supposed to replace the word copyright. But that seems to be our practice now.
-
laanwj commented at 8:05 AM on March 24, 2014: member
I vaguely remember that historically the reason that Copyright (C) is used in software is that (C) in itself is not the real copyright symbol and thus may not be valid in court. (There is ©, but using non-ASCII characters in C/C++ source is still non-portable)
But even if not strictly necessary anymore, please don't do an all-over-the-place update for this.
-
luke-jr commented at 8:10 AM on March 24, 2014: member
(Note you no longer have to make any copyright notice, at all, to have a valid copyright)
-
leofidus commented at 8:33 AM on March 24, 2014: none
@laanwj I realise we're getting off topic, but if "(c)" was not a valid option, why didn't people just use "Copyright"? "Copyright 2014" sounds unambigious, has no redundancy, looks good, uses no non-ASCII characters ... so why is "Copyright (c) 2014" so often prefered?
-
felipelalli commented at 4:27 PM on March 24, 2014: none
Actually isn't wrong as well to change all files to 2014, since the file is fundamental part of the entire project and the project was modified. The companies where I worked was used to change all copyright files (actually this could be automatic). It's just a convention of this project, and it's also ok! :)
-
gavinandresen commented at 4:36 PM on March 24, 2014: contributor
Please don't bikeshed this, we did that last year. Official Policy is to change the copyright year on the file if the file is changed in that year. Closing this pull request as Against Official Policy.
- gavinandresen closed this on Mar 24, 2014
- felipelalli deleted the branch on Mar 26, 2014
- felipelalli referenced this in commit b6b4809f81 on Mar 26, 2014
- DrahtBot locked this on Sep 8, 2021