Improve and expand base58 comments #4014

1. 
   shea256 commented at 2:32 am on April 7, 2014: contributor

   Made the grammar a bit more consistent, cleared up the checksum verification in DecodeBase58Check, and added a short note above the declaration of pszBase58 clarifying the characters that are omitted.
2. 
   laanwj commented at 5:29 am on April 7, 2014: member

   If you’re updating the comments here anyway, it’d be nice if you changed them so that those function documentations are picked up by doxygen (it currently shows no doc for them at all https://dev.visucore.com/bitcoin/doxygen/base58_8h.html#a2a7a6efa38bda9181b9a28ab3e675bea ).

   You can do this by using javadoc-style docblocks above the functions (or one of the shortened forms):

   0/**
   1 * ... text ...
   2 */
   

3. 
   shea256 commented at 2:46 am on April 8, 2014: contributor

   OK perfect, I’ll make that update.
4. 
   shea256 commented at 11:37 pm on April 8, 2014: contributor

   Just pushed a commit with javadoc-style docblocks. How does that look?
5. 
   laanwj commented at 8:14 am on April 9, 2014: member

   Looks good to me, ACK after squashing into one commit
6. 
   fanquake commented at 2:09 pm on April 12, 2014: member

   @rxl Any chance of get these squashed?
7. Improve and expand base58 comments

   update comments so doxygen will pick them up

   4e9667b844
8. 
   shea256 commented at 3:39 pm on April 12, 2014: contributor

   Done.
9. 
   BitcoinPullTester commented at 4:23 pm on April 12, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4e9667b844ac1c5fbb8934ec63fe17d2757f8767 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
10. 
    fanquake commented at 5:31 pm on April 12, 2014: member

    ACK
11. laanwj merged this on Apr 19, 2014
12. laanwj closed this on Apr 19, 2014

    ---

13. laanwj referenced this in commit 8da64ca47e on Apr 19, 2014
14. DrahtBot locked this on Sep 8, 2021

Contributors
shea256 laanwj fanquake BitcoinPullTester