Made the grammar a bit more consistent, cleared up the checksum verification in DecodeBase58Check, and added a short note above the declaration of pszBase58 clarifying the characters that are omitted.
Improve and expand base58 comments #4014
pull shea256 wants to merge 1 commits into bitcoin:master from shea256:master changing 1 files +38 −26-
shea256 commented at 2:32 AM on April 7, 2014: contributor
-
laanwj commented at 5:29 AM on April 7, 2014: member
If you're updating the comments here anyway, it'd be nice if you changed them so that those function documentations are picked up by doxygen (it currently shows no doc for them at all https://dev.visucore.com/bitcoin/doxygen/base58_8h.html#a2a7a6efa38bda9181b9a28ab3e675bea ).
You can do this by using javadoc-style docblocks above the functions (or one of the shortened forms):
/** * ... text ... */ -
shea256 commented at 2:46 AM on April 8, 2014: contributor
OK perfect, I'll make that update.
-
shea256 commented at 11:37 PM on April 8, 2014: contributor
Just pushed a commit with javadoc-style docblocks. How does that look?
-
laanwj commented at 8:14 AM on April 9, 2014: member
Looks good to me, ACK after squashing into one commit
-
-
4e9667b844
Improve and expand base58 comments
update comments so doxygen will pick them up
-
shea256 commented at 3:39 PM on April 12, 2014: contributor
Done.
-
BitcoinPullTester commented at 4:23 PM on April 12, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4e9667b844ac1c5fbb8934ec63fe17d2757f8767 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
fanquake commented at 5:31 PM on April 12, 2014: member
ACK
- laanwj merged this on Apr 19, 2014
- laanwj closed this on Apr 19, 2014
- laanwj referenced this in commit 8da64ca47e on Apr 19, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors