keys indexed by address + introduced CBitcoinaddress #403

1. 
   sipa commented at 9:31 am on July 13, 2011: member

   Three commits:

   • The first one gets rid of the global ‘mapPubKeys’, by indexing keys by address instead of by pubkey. This brings a consistent interface to CKeyStore, and testing for ownership of a key becomes a call to CKeyStore::HaveKey(), instead of doing a lookup in mapPubKeys.
   • The second one introduces the class CBitcoinAddress - represented by its raw data bytes (20 bytes containing the Hash160 of the pubkey), but convertible to string representation. In most places in the code, the use of a strAddress or hash160 as address identifier is replaced with CBitcoinAddress. (CAddress already existed, so I needed another name)
   • The third one splits code not specifically related to addresses into a common CBase58Data
2. 
   jgarzik commented at 4:00 am on July 15, 2011: contributor

   ACK
3. 
   TheBlueMatt commented at 0:20 am on July 16, 2011: member

   Looks good, ACK.
4. 
   sgimenez commented at 0:31 am on July 16, 2011: contributor

   Looks good. And those CBitcoinAddress types are a lot more informative than just strings.
5. get rid of mapPubKeys

   Make CKeyStore's interface work on uint160's instead of pubkeys, so
   no separate global mapPubKeys is necessary anymore.

   03fbd79049
6. Use CBitcoinAddress instead of string/uint160

   Instead of conversion functions between pubkey/uint160/address in
   base58.h, have a fully fledged class CBitcoinAddress (CAddress was
   already taken) to represent addresses.

   2ffba736e9
7. split off CBase58Data from CBitcoinAddress

   Split off features unrelated to addresses from CBitcoinAddress to
   CBase58Data, so they can be reused.

   cb61b8dc4c
8. Fix bug with accessing vchData[0] when vchData is empty.

   Fix typo in CBase58Data::CompareTo

   03f8b54565
9. Merge pull request #1 from AbrahamJewowich/cbitcoinaddress

   Cbitcoinaddress

   ca40e581eb
10. jgarzik referenced this in commit a9ba47101a on Jul 24, 2011
11. jgarzik merged this on Jul 24, 2011
12. jgarzik closed this on Jul 24, 2011

    ---

13. dexX7 referenced this in commit 2d29a2a254 on Jul 18, 2016
14. laanwj referenced this in commit 0ffb3bd95f on Aug 4, 2016
15. laanwj referenced this in commit b2135359b3 on Aug 16, 2016
16. MarcoFalke referenced this in commit 64dfdde0aa on Dec 13, 2016
17. deadalnix referenced this in commit 65285a63ee on Jan 19, 2017
18. ptschip referenced this in commit e1fe522053 on Apr 25, 2017
19. classesjack referenced this in commit c8e802e7db on Jan 2, 2018
20. sanch0panza referenced this in commit 638b66ecdb on May 17, 2018
21. sanch0panza referenced this in commit e6ac67451a on May 17, 2018
22. lateminer referenced this in commit cc2a29eac5 on Oct 16, 2019
23. cryptapus referenced this in commit 3bf2329d84 on May 3, 2021
24. rajarshimaitra referenced this in commit b9da90068a on Aug 5, 2021
25. DrahtBot locked this on Sep 8, 2021

Contributors
sipa jgarzik TheBlueMatt sgimenez