Bumps deps-linux, deps-win dependency versions as well.
qt-win does not need to be bumped, as although it depends on deps-win, Qt doesn't use miniupnp. I verified this by rebuilding the dependency and checking the the output is the same. Not having to rebuild Qt is a good thing as it is huge.
Bumps deps-linux, deps-win dependency versions as well.
qt-win does not need to be bumped, as although it depends on deps-win,
Qt doesn't use miniupnp. I verified this by rebuilding the dependency
and checking the the output is the same. Not having to rebuild Qt is a
good thing as it is huge.
Also move them to release-process.md from gitian-building.md for more
visibility.
ACK gitian builds work for me with this patch
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/219b512d726a2cf73b2abf66eafb6fd236118d0d for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
ACK. (Untested)
ACK (also untested). I did quickly review the miniupnpc 1.8-1.9 diff; besides scaring the pants off me with all the memcpy/strncpy, those changes look reasonable.
I'm not very happy about miniupnpc either. My first hunch was to propose removing it completely. But I suppose we could lose quite some nodes if we dropped it.. (or at least, dropped upnp support, there are alternative libraries that could be used but I'm not sure they are safer)