Changed bitrpc.py's raw_input to getpass for passwords to conceal command line input #4035

pull esbullington wants to merge 1 commits into bitcoin:master from esbullington:2014_04_bitrpc_py_getpass changing 1 files +4 −3

esbullington commented at 2:44 PM on April 9, 2014: contributor

Changed bitrpc.py's raw_input to getpass for passwords to conceal characters during command line input. Getpass is in Python stdlib so no additional dependencies required.

(first PR to Bitcoin, so hope the PR process and feature branch naming is OK -- I modelled the feature branch name format after laanwj's)
Changed bitrpc.py's raw_input to getpass for passwords to conceal characters during command line input. Getpass is in Python stdlib so no additional dependencies required. 0f63504463
BitcoinPullTester commented at 3:24 PM on April 9, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0f6350446344059d4818a94475cf6e21850dc198 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 8:48 PM on April 9, 2014: member

Code changes look good to me, haven't tested.
fanquake commented at 2:09 PM on April 12, 2014: member

ACK
laanwj merged this on Apr 22, 2014
laanwj closed this on Apr 22, 2014
laanwj referenced this in commit 91c601c54a on Apr 22, 2014
DrahtBot locked this on Sep 8, 2021

Contributors