variable was used before it was initialized #4096

pull tuttleorbuttle wants to merge 1 commits into bitcoin:master from tuttleorbuttle:bugfix changing 1 files +1 −1
  1. tuttleorbuttle commented at 2:54 PM on April 26, 2014: none

    not sure if there is some meaning i don't get but it looks like a merge error to me. this was just something i randomly noticed, sorry if it's intentional.

  2. variable was used before it was initialized 18b55d96a8
  3. BitcoinPullTester commented at 3:33 PM on April 26, 2014: none

    Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/18b55d96a82229a132c48108e6fbb04132bc59d0 for binaries and test log.

    This could happen for one of several reasons:

    1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
    2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
    3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
    4. The test suite fails on either Linux i386 or Win32
    5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

    If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

    This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. sipa commented at 3:35 PM on April 26, 2014: member

    This code is correct. It's a long-living static variable, and the callback is there to notify the GUI that the previous coinbase hash may now be available.

  5. sipa closed this on Apr 26, 2014

  6. MarcoFalke referenced this in commit 3f826598a4 on Mar 5, 2020
  7. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me