fuzz: UndefinedBehaviorSanitizer warnings in consensus/tx_verify.cpp #22233

issue n-thumann opened this issue on June 13, 2021

n-thumann commented at 3:04 PM on June 13, 2021: contributor

There's an error causing several CI jobs to fail, e.g. this, this, this or this.

INFO: Seed: 2688568392
INFO: Loaded 1 modules   (532968 inline 8-bit counters): 532968 [0x55d2f9ea7cf8, 0x55d2f9f29ee0), 
INFO: Loaded 1 PC tables (532968 PCs): 532968 [0x55d2f9f29ee0,0x55d2fa74bd60), 
INFO:     5306 files found in /tmp/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/coins_view
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1048576 bytes
INFO: seed corpus: files: 5306 min: 1b max: 3984182b total: 255622128b rss: 194Mb
[#1024](/bitcoin-bitcoin/1024/)	pulse  cov: 4978 ft: 17604 corp: 440/9989b exec/s: 512 rss: 247Mb
[#2048](/bitcoin-bitcoin/2048/)	pulse  cov: 5614 ft: 27538 corp: 763/47Kb exec/s: 409 rss: 333Mb
[#4096](/bitcoin-bitcoin/4096/)	pulse  cov: 5772 ft: 38611 corp: 1339/1242Kb exec/s: 204 rss: 350Mb
consensus/tx_verify.cpp:154:108: runtime error: implicit conversion from type 'int' of value -1653268223 (32-bit, signed) to type 'unsigned int' changed the value to 2641699073 (32-bit, unsigned)
    [#0](/bitcoin-bitcoin/0/) 0x55d2f6953400  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2ca9400)
    [#1](/bitcoin-bitcoin/1/) 0x55d2f64cafcd  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2820fcd)
    [#2](/bitcoin-bitcoin/2/) 0x55d2f64c5f39  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x281bf39)
    [#3](/bitcoin-bitcoin/3/) 0x55d2f63a6b97  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x26fcb97)
    [#4](/bitcoin-bitcoin/4/) 0x55d2f7c22647  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x3f78647)
    [#5](/bitcoin-bitcoin/5/) 0x55d2f7c222f5  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x3f782f5)
    [#6](/bitcoin-bitcoin/6/) 0x55d2f62ac531  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2602531)
    [#7](/bitcoin-bitcoin/7/) 0x55d2f62abc75  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2601c75)
    [#8](/bitcoin-bitcoin/8/) 0x55d2f62ae597  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x2604597)
    [#9](/bitcoin-bitcoin/9/) 0x55d2f62ae8f9  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x26048f9)
    [#10](/bitcoin-bitcoin/10/) 0x55d2f629d5ce  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x25f35ce)
    [#11](/bitcoin-bitcoin/11/) 0x55d2f62c6412  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x261c412)
    [#12](/bitcoin-bitcoin/12/) 0x7f7a8917c0b2  (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
    [#13](/bitcoin-bitcoin/13/) 0x55d2f627236d  (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x25c836d)
SUMMARY: UndefinedBehaviorSanitizer: implicit-integer-sign-change consensus/tx_verify.cpp:154:108 in 
MS: 0 ; base unit: 0000000000000000000000000000000000000000
artifact_prefix='./'; Test unit written to ./crash-d335a54e65799a7844ecde7d30f5e04719784b36

n-thumann added the label Bug on Jun 13, 2021
n-thumann commented at 3:07 PM on June 13, 2021: contributor

Should be solved by #22232.
MarcoFalke commented at 3:12 PM on June 13, 2021: member

Thanks for the report. I've fixed the ci issue via https://github.com/bitcoin-core/qa-assets/commit/a76dd626a6a39bcdfa2bc4afd1b81b02f6e721a2 temporarily.
preeti13456 commented at 4:45 PM on June 19, 2021: none

I'm interested in this issue can I have more clarity since one pr is merged already.
adamjonas commented at 12:10 PM on June 23, 2021: member

@preeti13456 if you are interested in helping with this issue, #22232 needs review.
preeti13456 commented at 1:20 PM on June 24, 2021: none

ok I'll look over some resources for the same and start working from next week itself.
MarcoFalke referenced this in commit 9faa4b68db on Jul 20, 2021
MarcoFalke closed this on Jul 20, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels

Linked (view graph)

#1 JSON-RPC support for mobile devices ("ultra-lightweight" clients)#2 Long-term, safe, store-of-value #3 Encrypt wallet #4 Export/Import wallet in a human readable, future-proof format #5 Make the version number the protocol version and not the client version #6 Treat wallet as a generic keystore #7 Block-header-only, faster startup client #8 RPC command to sign text with wallet private key #9 Fix for GUI on Macs and latest wxWidgets #10 Add address to listtransactions output #11 Nolisten patch #12 Monitor transactions and/or blocks #13 Messages with or about transactions #1024 correct passphrase crashes client after 50+ wrong guesses.#2048 Add "checkpoints" option, to permit disabling of checkpoint logic.#4096 variable was used before it was initialized #22232 refactor: Pass interpreter flags as uint32_t instead of signed int