remove -tor compatibility code (only allow -onion) #4130

1. 
   Diapolo commented at 6:35 PM on May 5, 2014: none

   • exit, if -tor option is found and give error to user

   IMHO the cleaner way now and less code to take care of.

2. laanwj added this to the milestone 0.10.0 on May 6, 2014
3. 
   Diapolo commented at 1:20 PM on May 20, 2014: none

   @gmaxwell AFAIK you introduced the current compatibility code, mind giving some thoughts ;)?

4. 
   laanwj commented at 6:53 AM on May 21, 2014: member

   Code changes look good to me, thanks for pruning the maze of option-parsing code a bit, haven't tested though.

5. 
   Diapolo commented at 3:53 PM on June 5, 2014: none

   Did anyone test this yet?

6. 
   BitcoinPullTester commented at 9:38 AM on June 23, 2014: none

   Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p4130_295639f859df96c17c01aedbd01453597b23ec6c/ for binaries and test log.

   This could happen for one of several reasons:

   1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
   2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
   3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
   4. The test suite fails on either Linux i386 or Win32
   5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

   If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

   This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

7. remove -tor compatibility code (only allow -onion)

   - exit, if -tor option is found and give error to user

   1c750dbd40
8. laanwj merged this on Jun 24, 2014
9. laanwj closed this on Jun 24, 2014

   ---

10. laanwj referenced this in commit 0410d11b3a on Jun 24, 2014
11. Diapolo deleted the branch on Jun 26, 2014
12. wtogami referenced this in commit 01c6f97b57 on Sep 9, 2014
13. wtogami referenced this in commit b09ad7b1f2 on Sep 19, 2014
14. wtogami referenced this in commit b0365462a3 on Oct 2, 2014
15. wtogami referenced this in commit 965633c682 on Nov 14, 2014
16. wtogami referenced this in commit a1e9939789 on Dec 23, 2014
17. DrahtBot locked this on Sep 8, 2021

Milestone
0.10.0