setaccount works on foreign addresses ! #4209

issue mFarghaly opened this issue on May 21, 2014

mFarghaly commented at 7:15 PM on May 21, 2014: none

if i associate account A with address mimoZNLcP2rrMRgdeX5PSnR7AjCqQveZZ4 that doesn't exist in my wallet and i don't has its private key, it will be added to my receiving addresses !

setaccount A mimoZNLcP2rrMRgdeX5PSnR7AjCqQveZZ4

I think address should be checked before association.
Diapolo commented at 8:41 PM on May 21, 2014: none

That account stuff should be removed asap...
laanwj added the label Wallet on May 26, 2014
laanwj added the label Priority Low on May 26, 2014
ghost commented at 10:37 PM on September 24, 2014: none

I would like to try and fix this low-priority issue, however, I'm not sure where to begin. (This is my first time trying to contribute to an opensource project.) What could I do to find where an issue is in the code?

EDIT: When I tried to reproduce this, it did not work. Is the issue already resolved? Or something else?

EDIT 2: I just thought of this and so I am currently looking at previously resolved issues in order to find where the code might be to fix this.
laanwj commented at 6:21 AM on September 25, 2014: member

The "setaccount" implementation in rpcwallet.cpp would be the place to start.
ghost commented at 8:40 PM on September 25, 2014: none

Okay, I have found it. Thanks for the pointer. I will see what I can figure out to try and fix this.
laanwj referenced this in commit 31d6390fd1 on Oct 2, 2014
ghost commented at 12:25 AM on October 9, 2014: none

Hey this issue is fixed. Let's close it. Are there many fixed issues that are still open?
laanwj commented at 10:36 AM on October 9, 2014: member

@ericshawlinux Yes, possible. Next time please use "Fixes #4209" somewhere in your commit message, then it will get closed automatically.
laanwj closed this on Oct 9, 2014
ghost commented at 12:32 PM on October 9, 2014: none

Okay
reddink referenced this in commit 90f40e2c04 on May 27, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#4985 Fixed setaccount accepting foreign address