Add another CNetAddr constructor which accepts boost::asio::ip::address #4301

pull 4tar wants to merge 1 commits into bitcoin:master from 4tar:cnetaddr_asio_constructor changing 6 files +37 −45
  1. 4tar commented at 4:38 AM on June 7, 2014: contributor

    By merging the independent BoostAsioToCNetAddr() function, this makes things a little bit more straightforward and clearer I think.

    Has mentioned in previous PR (https://github.com/bitcoin/bitcoin/pull/4299) which intended to collect feedback.

    Signed-off-by: Huang Le 4tarhl@gmail.com

  2. Add another CNetAddr constructor which accepts boost::asio::ip::address
    By merging the independent BoostAsioToCNetAddr() function, this makes things a little bit more straightforward and clearer I think.
    
    Signed-off-by: Huang Le <4tarhl@gmail.com>
    2de3ffc7c7
  3. BitcoinPullTester commented at 4:55 AM on June 7, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2de3ffc7c71e80a4feb7657961aa7e6219bdfc13 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  4. laanwj commented at 8:20 AM on June 7, 2014: member

    I intentionally made this a separate function to avoid having the netbase.h header depend on the boost::asio stuff (which slows down compile times a lot, for starters).

    In this case, would it be possible to predeclare boost::asio::ip::address so that the header include is not needed there?

  5. 4tar commented at 9:39 AM on June 7, 2014: contributor

    @laanwj Wow, I didn't notice that including the asio header would cause a compiling overhead, maybe because the building have already cost a long time;)

    It sounds smart to pre-declare the class, will submit a commit soon...

  6. 4tar closed this on Jun 7, 2014

  7. 4tar deleted the branch on Jun 7, 2014
  8. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me