By merging the independent BoostAsioToCNetAddr() function, this makes things a little bit more straightforward and clearer I think.
This is a renew of PR 4301 (https://github.com/bitcoin/bitcoin/pull/4301), the only change is to pre-declare the boost::asio::ip::address class instead of including asio.hpp in netbase.h to avoid increasing compiling time of those source files including it.
Signed-off-by: Huang Le 4tarhl@gmail.com
By merging the independent BoostAsioToCNetAddr() function, this makes things a little bit more straightforward and clearer I think.
Signed-off-by: Huang Le <4tarhl@gmail.com>
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4af4d2ea743ec08a2ffd652bf066f3f53d922571 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
:+1:
As commented elsewhere, I would really prefer netbase to not be dependent on boost::asio.
Right, as I've already explained to @4tar that was also my rationale for making it a separate conversion function.
However rpcserver.cpp was also no longer the right place once it's used outside the RPC subsystem - for #4299.
But boost::asio doesn't solve the problem there either, so my vote goes to closing this one and #4299.