A low priority tx of 226 bytes now pays 2260 satoshis in fee because of #3959. But if you set the voluntary fee to 10000 satoshis per kilobyte, CreateTransaction adds 10000 satoshis as fee instead of 2260.
At the end of the loop we check both, nMinFee and nPayFee, so start the loop always with zero fee.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/05e87c57e13449c6fa383cd7df0d6b56905a294a for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
@gavinandresen This changes your new fee code, can you comment here?
This would change the meaning of -paytxfee.
-paytxfee has meant "pay at least this many BTC (and pay this many BTC/kilobyte, if the transaction is larger than 1,000 bytes)."
I think we should deprecate -paytxfee once -txconfirmtarget is merged, so I don't think we should change the behavior now.
ok closing this. But then the descriptions in help and GUI have to be changed. It only says "Fee per kB to add to transactions you send".
Coin control also needs to be fixed, because currently cc assumes we never round. But in the voluntary case, we round now up to 1000 bytes. Else we never round.
I will submit a pr.