[Qt] Coin control cleanup because of non-rounding fees #4314

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz11 changing 1 files +18 −1

cozz commented at 12:29 AM on June 10, 2014: contributor
#3959 introduced that fees are not rounded anymore up to 1000 bytes.

This results in that coin control guesses the fee wrong very often. So I would like to make the change:
- add "~" in front of fee, afterfee and change; show a tooltip "Can vary +/- %1 satoshi(s) per input."
cozz renamed this:
~~Cozz11~~
[Qt] Coin control cleanup because of non-rounding fees
on Jun 10, 2014
cozz commented at 12:39 PM on June 11, 2014: contributor

update: After thinking about it, I only added the "~" and tooltips now.
gavinandresen commented at 6:24 PM on June 16, 2014: contributor

ACK. Tested on OSX.
[Qt] Change Coin control labels and tooltips because of non-rounding fees b3c912d93a
cozz commented at 8:43 PM on June 16, 2014: contributor
update:
- voluntary fee assumes now at least 1000 bytes. See #4308
BitcoinPullTester commented at 1:13 AM on June 23, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4314_b3c912d93a2d1cf98f894c28adaf94204174c6d7/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj merged this on Jun 23, 2014
laanwj closed this on Jun 23, 2014
laanwj referenced this in commit a652787737 on Jun 23, 2014

in src/qt/coincontroldialog.cpp:None in b3c912d93a

 520 | @@ -521,7 +521,7 @@ void CoinControlDialog::updateLabels(WalletModel *model, QDialog* dialog)
 521 |          sPriorityLabel = CoinControlDialog::getPriorityLabel(dPriority);
 522 |  
 523 |          // Fee
 524 | -        int64_t nFee = payTxFee.GetFee(nBytes);
 525 | +        int64_t nFee = payTxFee.GetFee(max((unsigned int)1000, nBytes));

rebroad commented at 3:48 PM on July 5, 2014:

This line gives a compiler error since nFee is not used.

MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#3959 estimatefee / estimatepriority RPC methods #4467 Remove unused variable