Now that downloads are no longer hosted on Sourceforge, update the script to retrieve the binaries and signature file from bitcoin.org.
Update verify.sh script to point to bitcoin.org #4441
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:2014_06_verify_script changing 2 files +5 −5-
fanquake commented at 5:21 AM on June 29, 2014: member
-
ffebc1be43
Update verify.sh script to point to bitcoin.org
Now that downloads are no longer hosted on Sourceforge, update the script to retrieve the binaries and signature file from bitcoin.org.
-
BitcoinPullTester commented at 5:37 AM on June 29, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4441_ffebc1be43751050c0b35d7140ba127783708d13/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- laanwj merged this on Jun 29, 2014
- laanwj closed this on Jun 29, 2014
- laanwj referenced this in commit a11f648585 on Jun 29, 2014
-
laanwj commented at 6:50 AM on June 29, 2014: member
This script surprises me. It downloads the files, verifies them, then deletes them all again. And it doesn't appear to have an option to keep them around.
-
fanquake commented at 6:52 AM on June 29, 2014: member
Yes, it does seem to do the bare minimum
-
laanwj commented at 7:00 AM on June 29, 2014: member
But I don't see the point. Say, you run verify.sh and it succeeds. It only proves that the executables downloaded by the script (and subsequently thrown away) are valid. If you use the positive output of verify.sh to download the executables again, you may get binaries that are tampered with.
Anyhow, not an important issue. Maybe this script is only used by Gavin to check whether he uploaded the right SHA256SUMS and sig.
- fanquake deleted the branch on May 12, 2016
- MarcoFalke locked this on Sep 8, 2021
Contributors