Fee fixes #4465

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz11 changing 4 files +24 −10

cozz commented at 1:53 PM on July 5, 2014: contributor
- fix bug in CWallet::CreateTransaction. If dPriorityNeeded is -1, then dPriority >= dPriorityNeeded is always true, so we always "break;"
- CFeeRate::GetFee(..) currently returns zero for very small nSatoshisPerK. For example, if you set the voluntary fee to 1 satoshi, and the tx has less than 1000 bytes, payTxFee.GetFee(nTxBytes) returns zero, this results in CWallet::GetMinimumFee(..) to return pool.estimateFee(..) instead of the voluntary fee. So its not possible to set the voluntary fee as low as 1 satoshi.
- Add fallback hard-coded AllowFree to coin control, because CreateTransaction also does.
- Handle voluntary fee case in coin control. nPayFee was set to zero if dPriority >= dPriorityNeeded, even in the voluntary fee case. And we need to consider, that CreateTransaction pays at least for 1000 bytes in the voluntary fee case.
Just a question, why did -mintxfee move from Testing options to Wallet options? I dont think we should bother people with this, otherwise we wouldnt need smart fee in the first place.
laanwj commented at 7:30 AM on July 7, 2014: member

Just a question, why did -mintxfee move from Testing options to Wallet options?

Because it is a wallet option. If you think it should be hidden as a debugging option put it behind the -help-debug flag.
laanwj added the label Wallet on Jul 7, 2014
gavinandresen commented at 2:34 PM on July 7, 2014: contributor

ACK. Good catch on the dPriorityNeeded = -1 bug.

I could quibble with the CFeeRate::GetFee() change (you cannot set a voluntary fee rate less than the hard-coded minRelayTxFee), but the code change is fine belt-and-suspenders.
Fee fixes d88af56011
BitcoinPullTester commented at 3:33 AM on July 8, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4465_d88af560111863c3e9c1ae855dcc287f04dffb02/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
cozz commented at 4:14 AM on July 8, 2014: contributor
update:
- rebased and hide -mintxfee by default from the command line help
laanwj merged this on Jul 8, 2014
laanwj closed this on Jul 8, 2014
laanwj referenced this in commit 7d05645693 on Jul 8, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7660 [amount] Extend GetFee() by optional flag ceil #7661 [wallet] Round up to the next satoshi on odd fee rates