[wallet] Round up to the next satoshi on odd fee rates #7661

pull MarcoFalke wants to merge 3 commits into bitcoin:master from MarcoFalke:Mf1603-walletCeil changing 5 files +85 −17

MarcoFalke commented at 4:17 PM on March 9, 2016: member

This requires #7660 to work.

You can already review this by just looking at 1923bb1 but I will rebase once #7660 is merged.

I consider the priority low on this, as this only happens with really small fee rates like 1 satoshi per kB, as mentioned in #4465#issue-37199263

[amount] Extend GetFee() by optional flag ceil

* This flag causes rounding up to the next satoshi instead of just
  truncating (default behavior)

* This reverts the hard-to-read and buggy code introduced in
  d88af560111863c3e9c1ae855dcc287f04dffb02

faccb1818c

Merge branch 'Mf1603-amountCeil' into HEAD f0058cdee4
[wallet] Round up to the next satoshi on odd fee rates 1923bb13de
morcos commented at 4:40 PM on March 9, 2016: member

@MarcoFalke I think this is going the wrong direction with making CFeeRate more convoluted. I think we could get rid of that $&$*! special case for 0, and be fine with the truncated version, or round normally, or ceiling all the time, but not make it optional.

We should also switch the internal representation to satoshis per MB or a double so that we could add a new member function to give greater precision, since mining doesn't use CFeeRate anyway and uses the actual fee per byte.
jonasschnelli added the label Wallet on Mar 10, 2016
laanwj commented at 7:27 AM on March 11, 2016: member

or a double

Please don't use floating point for monetary values.
jtimon commented at 5:03 PM on March 16, 2016: contributor

Sorry, I commented in #7660 (comment) before seeing this. I tend to agree with @morcos in that probably ceiling always would be better than an optional value.
MarcoFalke commented at 8:06 PM on March 16, 2016: member

Closing per IRC discussion.
MarcoFalke closed this on Mar 16, 2016
MarcoFalke deleted the branch on Mar 16, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#4465 Fee fixes #7660 [amount] Extend GetFee() by optional flag ceil