[Qt] Replace status bar unit icon with actual images #4466

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz7 changing 8 files +21 −3

cozz commented at 3:40 PM on July 5, 2014: contributor

The icon introduced by #4302 is too big in my opinion on the linuxes and windows I tested.

Reducing the font-size to 8pt comes close, but then its still vertically misaligned a few pixels depending on the desktop.

So this pull uses actual images, which look the same over all platforms and desktops.
[Qt] Replace status bar unit icon with actual images ad87bc4de1
rebroad commented at 3:55 PM on July 5, 2014: contributor

People will surely want the font to be in Tahoma font on Windows...?
BitcoinPullTester commented at 4:17 PM on July 5, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4466_ad87bc4de10d8ff9934635f2a30078ccf531a124/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 5:47 AM on July 7, 2014: member

ACK, good idea.
fanquake commented at 7:48 AM on July 7, 2014: member

ACK
laanwj merged this on Jul 7, 2014
laanwj closed this on Jul 7, 2014
laanwj referenced this in commit 88ae36bc06 on Jul 7, 2014
laanwj commented at 10:39 AM on July 20, 2014: member

The drawback of this is that on dark themes, the unit indicator is hard to read.

A low-prio improvement would be to make sure that the images are readable both on dark and light backgrounds (for example by adding a contour).
MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#4302 [Qt] New status bar Unit Display Control and related changes.