Clean up RPCs that are disabled in safe-mode. #4507

pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:safemode_cleanups changing 1 files +19 −19

gmaxwell commented at 5:12 PM on July 10, 2014: contributor

This removes some inconsistencies in what worked and didn't work in safemode. Now only RPCs involved in getting balances or sending funds are disabled.

Previously you could mine but not submit blocks— but we may need more blocks to resolve a fork that triggered safe mode in the first place, and the non-submission was not reliable since some miners submit blocks via multiple means. There were also a number of random commands disabled that had nothing to do with the blockchain like verifymessage.

Thanks to earlz for pointing out that there were some moderately cheap ways to maliciously trigger safe mode, which brought attention to the fact that safemode wasn't used in a very intelligent way.

Clean up RPCs that are disabled in safe-mode.

This removes some inconsistencies in what worked and didn't work in
 safemode. Now only RPCs involved in getting balances or sending
 funds are disabled.

Previously you could mine but not submit blocks— but we may need more
 blocks to resolve a fork that triggered safe mode in the first place,
 and the non-submission was not reliable since some miners submit
 blocks via multiple means. There were also a number of random commands
 disabled that had nothing to do with the blockchain like verifymessage.

Thanks to earlz for pointing out that there were some moderately cheap
 ways to maliciously trigger safe mode, which brought attention to
 the fact that safemode wasn't used in a very intelligent way.

b60be6be4a

sipa commented at 7:02 PM on July 10, 2014: member

Untested ACK.
BitcoinPullTester commented at 7:33 PM on July 10, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4507_b60be6be4a87cfe10bc32aefd8327df6c23d46e0/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 6:30 AM on July 11, 2014: member

Looks good to me, haven't tested, but changes are is trivial. ACK.
laanwj merged this on Jul 11, 2014
laanwj closed this on Jul 11, 2014
laanwj referenced this in commit 6ad2c2402e on Jul 11, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors