A CAutoFile is opened for the fees estimate, but it is only flushed/closed when the function ends. We can do that much earlier.
Also, avoid an assignment where a direct construction is possible.
Make sure CAutoFile for fees estimate goes out of scope #4546
pull sipa wants to merge 1 commits into bitcoin:master from sipa:closeest changing 1 files +8 −6-
sipa commented at 7:47 PM on July 16, 2014: member
-
Make sure CAutoFile for fees estimate goes out of scope 09c744c2a8
-
jgarzik commented at 8:15 PM on July 16, 2014: contributor
ut ACK
-
BitcoinPullTester commented at 8:31 PM on July 16, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4546_09c744c2a845f756adbcf8716c2365b63731f467/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
gmaxwell commented at 10:14 PM on July 16, 2014: contributor
(tested) ACK
- laanwj merged this on Jul 17, 2014
- laanwj closed this on Jul 17, 2014
- laanwj referenced this in commit 00b16bc942 on Jul 17, 2014
- MarcoFalke locked this on Sep 8, 2021
Contributors