Rebased and bike-shed version of #4234
Use a typedef for monetary values #4614
pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:typedef2 changing 58 files +354 −319-
jtimon commented at 12:20 AM on August 1, 2014: contributor
-
Use a typedef for monetary values 0adf98ed38
-
BitcoinPullTester commented at 12:34 AM on August 1, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4614_0adf98ed38c706ebae07a0d74bf6bab18e1b9f42/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
maaku commented at 2:52 AM on August 1, 2014: contributor
I updated the original PR.
-
laanwj commented at 7:22 AM on August 1, 2014: member
ACK (checked that it only changes type names using sipa's
git show --word-diff-regex='[[:alnum:]]+|[^[:space:]]) - laanwj added the label Improvement on Aug 1, 2014
-
gmaxwell commented at 10:20 PM on August 1, 2014: contributor
ACK. I like this, I generally prefer more specific typing.
-
bpay commented at 11:05 PM on August 1, 2014: contributor
Why the change to pass by const ref? For something that small you'll likely get better codegen just passing by value.
-
-
-
- jtimon closed this on Aug 2, 2014
- jtimon deleted the branch on Aug 11, 2014
- DrahtBot locked this on Sep 8, 2021
Labels