Encapsulate & protect core class COutPoint #4662

A bit of an exploration, to see if we want to do this.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4662_ed6d34baf45a9520043982aea9c97691e51badf7/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

I know that this is the "OO-way", but I'm not sure there is any advantage to regarding CTxOut as an opaque, encapsulated object instead of just a dumb core data structure. We all know very well what is in it, we're fairly sure it won't change (unless the blockchain protocol changes), so the advantage of practising data hiding is uncertain.

However, it pretty much a matter of taste and I'm not against this either.

Yeah, I'd lean towards "dumb core data structure" myself. Given it's consensus critical, having all the details be directly visible is probably not a bad thing.

Of course, I'm biased as then it'd make python-bitcoinlib be different than the core codebase it's meant to copy; I'd have to at least update the README. ;)

I have to agree with the two above. Keeping it a POD non-OO structure seems cleaner to me, despite the non-OO look.

That's fine. As noted, this was speculative. Closing. POD alive and free.