I tested sendrawtransaction, tx showed up in the GUI. Tested sending a tx, then start new wallet and wait for tx from block, tx showed up in the GUI.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4716_0d27dad8452704fa849832a0d28bf3e1b564d7b7/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Untested ACK on each of the changes.
ConnectBlock is called from more places than just ConnectTip. The only possibly problematic case I see is the call from CreateNewBlock by the internal miner. Missing the wallet update there may cause some transactions to not be properly updated in the GUI.
@laanwj Can you describe such a scenario? A miner only mines txs from the mempool, this means the txs are in the wallet as unconfirmed already, as we sync them to the wallet in AcceptToMemoryPool. Now if they get confirmed, they will be synced again through ConnectTip, independent of 'who has found the block'. The coinbase tx also gets synced through ConnectTip, if the block makes it temporarily or permanent in the main chain. If the block gets orphaned immediately, I dont think anybody cares about that coinbase tx.
@laanwj The case of CreateNewBlock calling ConnectBlock directly is an argument in favor of why ConnectBlock shouldn't do wallet callbacks - it's a more low-level function that just applies the UTXO state changes of a block. As @cozz says, ConnectTip is called indirectly when a new block gets accepted.
OK. Untested ACK.