Remove print() from core classes #4735

pull laanwj wants to merge 3 commits into bitcoin:master from laanwj:2014_08_core_print changing 15 files +15 −90
  1. laanwj commented at 8:55 am on August 20, 2014: member

    Remove unused print()s and change the instance on CBlock to ToString(). Breaks dependency from core.o on util.o.

    Before:

     0src/libbitcoin_common_a-core.o
     1  src/crypto/crypto_libbitcoin_crypto_a-sha2.o
     2    CSHA256::Reset(...)
     3    CSHA256::Write(...)
     4    CSHA256::Finalize(...)
     5    CSHA256::CSHA256(...)
     6  src/libbitcoin_common_a-script.o
     7    GetOpName(...)
     8  src/libbitcoin_util_a-uint256.o
     9    base_uint<256u>::EqualTo(...)
    10    base_uint<256u>::ToString(...)
    11  src/libbitcoin_util_a-util.o
    12    FormatMoney(...)
    13    LogPrintStr(...)
    14    LogAcceptCategory(...)
    

    After:

     0src/libbitcoin_common_a-core.o
     1  src/crypto/crypto_libbitcoin_crypto_a-sha2.o
     2    CSHA256::Reset(...)
     3    CSHA256::Write(...)
     4    CSHA256::Finalize(...)
     5    CSHA256::CSHA256(...)
     6  src/libbitcoin_common_a-script.o
     7    GetOpName(...)
     8  src/libbitcoin_util_a-uint256.o
     9    base_uint<256u>::EqualTo(...)
    10    base_uint<256u>::ToString(...)
    
  2. Remove print() from core functions
    Break dependency on util.
    81212588c0
  3. Move strprintf define to tinyformat.h
    This avoids a dependency on util.h if just tinyformat is needed.
    9b6d4c5cdc
  4. laanwj added the label Improvement on Aug 20, 2014
  5. Remove all other print() methods
    All unused.
    3802224110
  6. BitcoinPullTester commented at 7:14 pm on August 20, 2014: none
    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4735_380222411038cb4f74cbb109984c4b855b4799f6/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
  7. TheBlueMatt commented at 8:09 pm on August 20, 2014: member
    ut ACK
  8. sipa commented at 11:21 pm on August 20, 2014: member
    ut ACK
  9. laanwj merged this on Aug 21, 2014
  10. laanwj closed this on Aug 21, 2014

  11. laanwj referenced this in commit 93ed3d9b4e on Aug 21, 2014
  12. jgarzik commented at 2:12 pm on August 21, 2014: contributor
    posthumous ut ACK
  13. laanwj referenced this in commit a2a3f4ba2c on Jun 27, 2016
  14. laanwj referenced this in commit 1666e37fb7 on Jun 27, 2016
  15. laanwj referenced this in commit 695041e495 on Jun 27, 2016
  16. zkbot referenced this in commit 6bad499c2a on Oct 25, 2016
  17. protonn referenced this in commit 2e09c3d7f1 on May 7, 2017
  18. lateminer referenced this in commit 0320890116 on Jan 3, 2019
  19. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me