Remove CScriptCheck::nHashType (was always 0) #4775

1. 
   jtimon commented at 9:11 am on August 28, 2014: contributor

   It’s only used in one place and CScriptCheck can be used directly instead. Also remove CScriptCheck::nHashType since was always 0. In preparation of #4555
2. jtimon renamed this:
   Remove unused function main:VerifySignature
   Remove unused function main::VerifySignature
   on Aug 28, 2014
3. jtimon renamed this:
   Remove unused function main::VerifySignature
   Remove CScriptCheck::nHashType (was always 0)
   on Aug 28, 2014
4. jtimon force-pushed on Aug 28, 2014
5. laanwj added the label TX scripts on Aug 28, 2014
6. 
   sipa commented at 0:40 am on August 30, 2014: member

   Needs rebase, but ut ACK.
7. 
   laanwj commented at 2:49 am on August 30, 2014: member

   Agree on removing the VerifySignature function that is only used by the tests.

   NACK on partially removing CScriptCheck::nHashType. Either it should be removed completely and this removal propagated through VerifyScript, or it would be better to keep it like this. Mind that CScriptCheck is meant to be a closure around VerifyScript (so should expose the same arguments). Now you just push the hardcoded 0 to CScriptCheck::operator()().

8. 
   laanwj commented at 3:03 am on August 30, 2014: member

   Oh, that’s what you do in #4555, well then it’s fine with me.
9. Remove unused function main:VerifySignature a3b7d95450
10. Remove CScriptCheck::nHashType (was always 0) 5ad29370ed
11. jtimon force-pushed on Aug 30, 2014
12. 
    jtimon commented at 8:14 am on August 30, 2014: contributor

    Rebased
13. 
    BitcoinPullTester commented at 8:27 am on August 30, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4775_5ad29370edc22558539bd89135c02d3de4c7bc52/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
14. 
    TheBlueMatt commented at 6:30 am on September 2, 2014: member

    ut ACK.
15. 
    jtimon commented at 9:01 pm on September 8, 2014: contributor

    Included in #4555, after #4754 has been merged there’s no point in keeping this one separated.
16. jtimon closed this on Sep 8, 2014

    ---

17. jtimon deleted the branch on Sep 8, 2014
18. MarcoFalke locked this on Sep 8, 2021

Contributors
jtimon sipa laanwj BitcoinPullTester TheBlueMatt

Labels
Validation