Some simplifications (unnecessary fRead, pthis and me variables) after #4737.
Serializer simplifications after #4737 #4808
pull sipa wants to merge 2 commits into bitcoin:master from sipa:simpleserial changing 13 files +84 −107-
sipa commented at 7:37 PM on September 1, 2014: member
- sipa renamed this:
Serializer simplifications after IMPLEMENT_SERIALIZE overhaul
Serializer simplifications after #4737
on Sep 1, 2014 - sipa force-pushed on Sep 1, 2014
-
Serializer simplifications after IMPLEMENT_SERIALIZE overhaul 47eb76597e
- sipa force-pushed on Sep 1, 2014
-
TheBlueMatt commented at 7:43 AM on September 2, 2014: member
ut ACK, though I'd also like to see IMPLEMENT_SERIALIZE renamed to something that describes what it actually does now.
-
Rename IMPLEMENT_SERIALIZE to ADD_SERIALIZE_METHODS 3f6540ad8f
-
sipa commented at 8:09 AM on September 2, 2014: member
@TheBlueMatt Done.
-
TheBlueMatt commented at 8:13 AM on September 2, 2014: member
ut ACK.
-
BitcoinPullTester commented at 8:23 AM on September 2, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4808_3f6540ad8f9c7b45a0dd2b260a282d3adad2406f/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
jtimon commented at 10:02 AM on September 3, 2014: contributor
Yes, kill those "pthis" an "me" pointers to "this", that was very confusing. ut ACK.
-
laanwj commented at 11:01 AM on September 3, 2014: member
Untested ack
- sipa merged this on Sep 3, 2014
- sipa closed this on Sep 3, 2014
- sipa referenced this in commit 961c4a04c2 on Sep 3, 2014
- MarcoFalke locked this on Sep 8, 2021
Contributors