Preview: Compile a standalone VerifyScript() #4809

1. 
   jtimon commented at 11:28 pm on September 1, 2014: contributor

   This is how something close to #4692 could look like after merging #4775 #4754 #4755 and #4555 @TheBlueMatt you could code the C API on top of commit “Compile a standalone VerifyScript()”.
2. Remove unused function StackString() and class CCoins; 8d5e5102f6
3. Discover some missing includes 53efb09e4c
4. Rename script.h/.cpp to scriptutils.h/.cpp (plus remove duplicated includes) a5ac63deb3
5. Move CScript class and dependencies to script/script 3bcdca6b9f
6. Separate script/interpreter 36dc780db6
7. Separate script/standard ad80b044a6
8. Separate CScriptCompressor 24ce53d2ae
9. Separate script/sign 24eb154855
10. Move scriptutils.o to wallet 46fe90bdc8
11. Move CAffectedKeysVisitor to wallet.cpp (remove ExtractAffectedKeys) 31cbecf566
12. Rename scriptutils.o to wallet_ismine.o ad52c234d9
13. Remove unused function main:VerifySignature d07dc11ccd
14. Remove CScriptCheck::nHashType (was always 0) 039ff17065
15. Don't pass nHashType to VerifyScript 36663ac332
16. Don't pass nHashType to EvalScript nor CheckSig 93640f6fb4
17. Decouple interpreter from core 38074cc2b9
18. move transaction serializer out of script_score.cpp 7cbd86f291
19. template CTransactionSignatureSerializer d26e58e550
20. Compile a standalone VerifyScript() eefc0d995c
21. jtimon force-pushed on Sep 2, 2014
22. 
    BitcoinPullTester commented at 1:58 am on September 2, 2014: none

    Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p4809_eefc0d995c096292d26fc8289c4e9ae1e519a938/ for binaries and test log.

    This could happen for one of several reasons:

    1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
    2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
    3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
    4. The test suite fails on either Linux i386 or Win32
    5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

    If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

    This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

23. 
    jtimon commented at 10:15 am on September 2, 2014: contributor

    Needs rebase and it was only to show the idea. People can still read it while closed and I have too many open PRs: closing until #4754 is merged.
24. jtimon closed this on Sep 2, 2014

    ---

25. MarcoFalke locked this on Sep 8, 2021

Contributors
jtimon BitcoinPullTester