Construct char vchZero[0] = {}; is illegal on Microsoft compiler. The constant expression for the array size must be an integer greater than zero. For more info please see: http://msdn.microsoft.com/en-us/library/6zxfydcs.aspx
Adding one element seams to be quick and safe fix.
untested ACK
Code-review ACK.
PS: unrelated to this pull, but there is dead code in script.cpp:
./script.cpp:static const valtype vchZero(0);
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4810_c0f5d4aba5e158d32edb3fc280f63e04542e90d4/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Maybe the most elegant would be to make it 32 bytes, like everything else that has to do with keys. CompareBigEndian can be shorter if it can always assume c1len==c2len==32.
Anyhow, ACK on this solution, it's safe and gets it to compile.
ut ACK.
ut ACK