I tried to download some source from the Github download link, and it's not building correctly.
Here are the errors I was getting: https://bitcointalk.org/index.php?topic=40899.msg498776#msg498776
If you open https://github.com/bitcoin/bitcoin - you can see the download button on the right-hand side of the page in gray. Do we know what has been pushed to this and how?
Does it automatically create versions for us?
That download button is (AFAIK) always a copy of current git master branch.
When I did a build using the download button's source I received the above errors. When building it moments later from git clone; I did not. I'll try to run a diff and see what's going on.
I ran diff and couldn't find any issues, but I noticed one file that was a different size in the download vs the git clone. The downloaded source uses Dos\Windows newline formatting whereas the git clone uses UNIX. A subtle difference, but apparently enough to cause a build error.
I have a feeling that unzipping the download with 7zip in windows 7 may have caused this.
That is indeed the problem. 7zip adds Dos\Windows line endings instead of UNIX when unzipping a .zip file. Interestingly; the built-in Microsoft archive manager does not.