Avoid reject message feedback loops #4903

1. 
   sipa commented at 2:38 pm on September 12, 2014: member
2. 
   gavinandresen commented at 3:06 pm on September 12, 2014: contributor

   ACK
3. 
   jgarzik commented at 3:11 pm on September 12, 2014: contributor

   ut ACK
4. 
   laanwj commented at 3:13 pm on September 12, 2014: member

   ACK, with one nit: please a debug message when an exception happens. I think completely ignoring it is not a good idea for troubleshooting and such.
5. 
   sipa commented at 3:20 pm on September 12, 2014: member

   I was trying to avoid introducing any risk of causing another exception while writing a debug log message.
6. sipa force-pushed on Sep 12, 2014
7. 
   sipa commented at 3:27 pm on September 12, 2014: member

   Moved the catch inside the if (fDebug), and made it print a debug message.
8. in src/main.cpp: in 18dde96cb5 outdated

   4132+                    ss << ": hash " << hash.ToString();
   4133+                }
   4134+                LogPrint("net", "Reject %s\n", SanitizeString(ss.str()));
   4135+            } catch (std::ios_base::failure& e) {
   4136+                // Avoid feedback loops by preventing reject messages from triggering a new reject message.
   4137+                LogPrint("net", "Unparseable reject message received");
   

   ---

   ---

   

   laanwj commented at 3:46 pm on September 12, 2014:

   Message needs a \n at the end
9. 
   gavinandresen commented at 3:46 pm on September 12, 2014: contributor

   reviewed-but-untested-but-don’t-think-testing-is-necessary-ACK
10. Avoid reject message feedback loops efad808aae
11. sipa force-pushed on Sep 12, 2014
12. 
    BitcoinPullTester commented at 4:06 pm on September 12, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4903_efad808aaece74a0308a77e35ad35e845edb97f8/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
13. 
    gmaxwell commented at 10:32 pm on September 15, 2014: contributor

    I can test, have a reproduction already.
14. 
    laanwj commented at 8:55 am on September 16, 2014: member

    @gmaxwell That’s great
15. 
    gmaxwell commented at 4:11 pm on September 16, 2014: contributor

    Tests out fine, I see it log the unparsable reject message. ACK.
16. sipa merged this on Sep 16, 2014
17. sipa closed this on Sep 16, 2014

    ---

18. sipa referenced this in commit 13168ea46c on Sep 16, 2014
19. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa gavinandresen jgarzik laanwj BitcoinPullTester gmaxwell