Avoid reject message feedback loops #4903

pull sipa wants to merge 1 commits into bitcoin:master from sipa:norejloop changing 1 files +16 −12

sipa commented at 2:38 PM on September 12, 2014: member

No description provided.
gavinandresen commented at 3:06 PM on September 12, 2014: contributor

ACK
jgarzik commented at 3:11 PM on September 12, 2014: contributor

ut ACK
laanwj commented at 3:13 PM on September 12, 2014: member

ACK, with one nit: please a debug message when an exception happens. I think completely ignoring it is not a good idea for troubleshooting and such.
sipa commented at 3:20 PM on September 12, 2014: member

I was trying to avoid introducing any risk of causing another exception while writing a debug log message.
sipa force-pushed on Sep 12, 2014
sipa commented at 3:27 PM on September 12, 2014: member

Moved the catch inside the if (fDebug), and made it print a debug message.

in src/main.cpp:None in 18dde96cb5 outdated

4132 | +                    ss << ": hash " << hash.ToString();
4133 | +                }
4134 | +                LogPrint("net", "Reject %s\n", SanitizeString(ss.str()));
4135 | +            } catch (std::ios_base::failure& e) {
4136 | +                // Avoid feedback loops by preventing reject messages from triggering a new reject message.
4137 | +                LogPrint("net", "Unparseable reject message received");

laanwj commented at 3:46 PM on September 12, 2014:

Message needs a \n at the end

gavinandresen commented at 3:46 PM on September 12, 2014: contributor

reviewed-but-untested-but-don't-think-testing-is-necessary-ACK
Avoid reject message feedback loops efad808aae
sipa force-pushed on Sep 12, 2014
BitcoinPullTester commented at 4:06 PM on September 12, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4903_efad808aaece74a0308a77e35ad35e845edb97f8/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
gmaxwell commented at 10:32 PM on September 15, 2014: contributor

I can test, have a reproduction already.
laanwj commented at 8:55 AM on September 16, 2014: member

@gmaxwell That's great
gmaxwell commented at 4:11 PM on September 16, 2014: contributor

Tests out fine, I see it log the unparsable reject message. ACK.
sipa merged this on Sep 16, 2014
sipa closed this on Sep 16, 2014
sipa referenced this in commit 13168ea46c on Sep 16, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors