depends: update the comparison tool to a more recent version #5006

1. 
   TheBlueMatt commented at 5:41 am on September 30, 2014: member

   Updated version of #4837
2. TheBlueMatt force-pushed on Sep 30, 2014
3. TheBlueMatt force-pushed on Sep 30, 2014
4. 
   theuni commented at 4:47 pm on September 30, 2014: member

   Great, thanks for doing this. What’s the current status of it, though? Is this just an updated snapshot, or does it include some of the more extensive tests that have been discussed lately?

   Also, it’s going to need a distinct file-name, otherwise this will clash with the next update. Could you please append the upstream revision to the jar’s filename, so that we can keep track of what this build corresponds to? Notice how #4837 used pull-tests-$($(package)_version).jar for the file-name, which addresses both concerns at once.

5. 
   TheBlueMatt commented at 5:08 pm on September 30, 2014: member

   This version supports headers-first with one slight tweak to sipa’s current branch. Note the download link includes the commithash to avoid update conflicts.
6. 
   theuni commented at 5:14 pm on September 30, 2014: member

   That won’t help here, though. Next update, it’ll see that it has already fetched pull-tests.jar, so it will skip it this time. Then the checksum will fail.

   There’s no indication of what upstream revision this corresponds to, so we’re in the same position as current pull-tester (blind). Even if it’s some random commit on one of your personal branches, please make a note of what this corresponds to. The filename is the most obvious place for that.

7. TheBlueMatt force-pushed on Sep 30, 2014
8. 
   TheBlueMatt commented at 5:51 pm on September 30, 2014: member

   Fixed.
9. 
   theuni commented at 7:09 pm on September 30, 2014: member

   @TheBlueMatt I realize it sounds nitpicky, but please build the filename from the version string. It’s used to calculate the dependency chain. With any other dep/lib it makes sense, but this one’s a bit weird since it’s not a normal source release. This should work:

   0$(package)_version=adfd3de7
   1$(package)_download_path=https://github.com/TheBlueMatt/test-scripts/raw/10222bfdace65a0c5f3bd4a766eeb6b3a8b869fb/
   2$(package)_file_name=pull-tests-$($(package)_version).jar
   

   You can also use the branch name since filenames will be unique, that way bumping the version/hash is all it takes to update in the future:

   0$(package)_download_path=https://github.com/TheBlueMatt/test-scripts/raw/master
   

   But that’s up to you.

   After that, ACK from me on the deps side of things, but the actual behavior changes still need review. paging @sipa

10. depends: update the comparison tool to a more recent version 6d7a0fa4e5
11. Revert "travis: retry tests before giving up"

    This reverts commit 7e3821c097c05a4790abac53ddd26ef28cb7cf4d.

    e166c177bc
12. TheBlueMatt force-pushed on Sep 30, 2014
13. 
    TheBlueMatt commented at 7:14 pm on September 30, 2014: member

    Fixed.
14. 
    TheBlueMatt commented at 7:14 pm on September 30, 2014: member

    (I’d prefer to be able to clear random crap from master, so I’m gonna avoid using master for the download path for now)
15. 
    theuni commented at 7:29 pm on September 30, 2014: member

    Thanks. Looks good now.
16. 
    BitcoinPullTester commented at 7:47 pm on September 30, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p5006_e166c177bccdaf5b3c1b2238e8e04d53554d138e/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
17. 
    sipa commented at 9:21 pm on September 30, 2014: member

    Tested ACK
18. 
    sipa commented at 9:30 pm on September 30, 2014: member

    This was tested using #5011, #5012 and #5009.
19. 
    theuni commented at 11:45 pm on September 30, 2014: member

    ACK
20. gavinandresen referenced this in commit 7def85e1b5 on Sep 30, 2014
21. gavinandresen merged this on Sep 30, 2014
22. gavinandresen closed this on Sep 30, 2014

    ---

23. MarcoFalke locked this on Sep 8, 2021

Contributors
TheBlueMatt theuni BitcoinPullTester sipa