Small improvements on a couple of debug messages #5017

1. 
   jtimon commented at 11:50 pm on September 30, 2014: contributor

   Taking a little bit of @maaku’s work on Freicoin back to Bitcoin.
2. in src/main.cpp: in 00000a5eed outdated

   1360@@ -1361,7 +1361,8 @@ bool CheckInputs(const CTransaction& tx, CValidationState &state, const CCoinsVi
   1361         }
   1362 
   1363         if (nValueIn < tx.GetValueOut())
   1364-            return state.DoS(100, error("CheckInputs() : %s value in < value out", tx.GetHash().ToString()),
   1365+            return state.DoS(100, error("CheckInputs() : %s value in < value out (%s < %s)",
   1366+                                        tx.GetHash().ToString(), FormatMoney(nValueIn), FormatMoney(tx.GetValueOut())),
   

   ---

   ---

   

   TheBlueMatt commented at 11:52 pm on September 30, 2014:

   Can you do “%s value in (%s) < value out (%s)”?
3. 
   laanwj commented at 1:11 pm on October 1, 2014: member

   0main.cpp: In function ‘bool CheckInputs(const CTransaction&, CValidationState&, const CCoinsViewCache&, bool, unsigned int, std::vector<CScriptCheck>*)’:
   1
   2main.cpp:1365:86: error: ‘FormatMoney’ was not declared in this scope
   

4. When transaction outputs exceed inputs, show the offending amounts so as to aid debugging. 217a5c9238
5. Print input index when signature validation fails, to aid debugging. f74fc9b22d
6. jtimon force-pushed on Oct 1, 2014
7. 
   jtimon commented at 6:11 pm on October 1, 2014: contributor

   Fixed @TheBlueMatt ’s nit and compile error.
8. 
   TheBlueMatt commented at 8:53 pm on October 1, 2014: member

   utACK
9. 
   sipa commented at 2:06 am on October 2, 2014: member

   utACK
10. laanwj merged this on Oct 2, 2014
11. laanwj closed this on Oct 2, 2014

    ---

12. laanwj referenced this in commit 00eef5d6e9 on Oct 2, 2014
13. MarcoFalke locked this on Sep 8, 2021

Contributors
jtimon TheBlueMatt laanwj sipa