Update comparison tool #5035

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:comptool changing 1 files +3 −3

TheBlueMatt commented at 8:17 PM on October 2, 2014: member

...and include a commit to test it breaking.
TheBlueMatt force-pushed on Oct 2, 2014
Make comptool more deterministic c9c51cba4e
TheBlueMatt force-pushed on Oct 2, 2014
TheBlueMatt commented at 8:52 PM on October 2, 2014: member

OK, tested this with fail commits on either side of MAX_BLOCK_SIZE, so this is ready for ACKs when it finishes the next test run.
laanwj commented at 6:48 AM on October 3, 2014: member

Just out of interest, can you link to the git diff as well? I've tried

https://code.google.com/r/bluemattme-bitcoinj/source/browse/core/src/test/java/com/google/bitcoin/core/BitcoindComparisonTool.java?name=blocktester

as you mention in the README that accompanies the jars, but it seems broken.
TheBlueMatt commented at 6:55 AM on October 3, 2014: member

Sorry, its now https://github.com/TheBlueMatt/bitcoinj/tree/blocktester
laanwj commented at 7:04 AM on October 3, 2014: member

Thanks!
theuni commented at 6:01 PM on October 3, 2014: member

ACK, I suppose. Any chance of getting this stuff cleaned up and upstreamed?
TheBlueMatt commented at 6:17 PM on October 3, 2014: member

Meh, the upstream bitcoinj stuff is broken and I'm lazy...maybe at some point I'll do that, but for now I dont care so much.
laanwj merged this on Oct 4, 2014
laanwj closed this on Oct 4, 2014
laanwj referenced this in commit 5bf029603c on Oct 4, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors