New wallet encryption + small fixes
Spanish translation update #504
pull paraipan wants to merge 1 commits into bitcoin:master from paraipan:master changing 2 files +567 −458-
paraipan commented at 8:27 PM on September 6, 2011: contributor
-
Spanish translation update 2aa8c37deb
-
alexwaters commented at 10:35 PM on September 6, 2011: contributor
ACK
-
TheBlueMatt commented at 11:42 PM on September 6, 2011: member
Can you remove the binary mo file?
-
paraipan commented at 11:49 PM on September 6, 2011: contributor
eh ? dunno how it shows up but the binary has been deleted
-
TheBlueMatt commented at 12:12 AM on September 7, 2011: member
Oh, you deleted it, my bad. I thought it had been modified. ACK
-
paraipan commented at 12:15 AM on September 7, 2011: contributor
np :)
-
jgarzik commented at 3:12 AM on September 11, 2011: contributor
The commit deletes *.mo, which is not the desired effect.
Your commit needs to simply modify *.po, and touch nothing else.
Thanks.
-
paraipan commented at 11:54 AM on September 11, 2011: contributor
yeah, that would be my goal in every commit but with this one i had some troubles cause the editor overwrites the *.mo at the same time when you save the translation. I didn't know it was this difficult for you guys to manage submitted work from other people, i will try not to bother again. Thanks
-
jgarzik commented at 6:53 PM on September 11, 2011: contributor
It becomes difficult for the very few engineers with pull requests, if each pull request requires manual modification after it is submitted.
It is -normal- in an open source project to request the submittor update their pull request in response to feedback. See the Linux kernel, or Apache, or Eclipse, or any number of other open source projects for similar feedback-response-update workflow.
Only by working together, through a normal conversation with feedback and response, do open source projects succeed.
-
paraipan commented at 7:59 PM on September 11, 2011: contributor
thanks jgarzik for taking your time to explain this issue, i do not fully agree here but will not continue with probably already answered questions. A "committer guide" will be nice though to maintain some order and less troubles for the main devel :)
I'm not experienced with git so i will be redoing all the forking and committing stuff to fully comply, doing your work harder was not my intention.
- paraipan closed this on Sep 11, 2011
- ptschip referenced this in commit 06da363bb8 on May 2, 2017
- rajarshimaitra referenced this in commit 2ed2d0518a on Aug 5, 2021
- DrahtBot locked this on Sep 8, 2021
- DrahtBot added the label CI failed on Apr 2, 2023
- DrahtBot removed the label CI failed on Apr 2, 2023
- DrahtBot added the label CI failed on Apr 2, 2023
- DrahtBot removed the label CI failed on Apr 3, 2023
- DrahtBot added the label CI failed on Apr 5, 2023
- MarcoFalke removed the label CI failed on Apr 5, 2023