Enable customising node policy for datacarrier data size with a -datacarriersize option #5077

1. 
   luke-jr commented at 11:56 pm on October 10, 2014: member

   This seems to be something miners want control over.
2. 
   TheBlueMatt commented at 7:32 am on October 11, 2014: member

   Link/summary to miner requests?
3. 
   luke-jr commented at 7:53 am on October 11, 2014: member

   The (5-10 people? not big) Eligius tx policy discussion concluded on 80 byte OP_RETURNs, and I’ve personally observed various positive reactions from random third parties in response, though I didn’t save links or anything.
4. 
   TheBlueMatt commented at 8:18 am on October 11, 2014: member

   What are those third parties? If they are parties using the chain to store data when they could otherwise only store commitments, I’m not sure we want to support them more?
5. in src/script/standard.cpp: in 2b404e8598 outdated

   136@@ -137,7 +137,7 @@ bool Solver(const CScript& scriptPubKey, txnouttype& typeRet, vector<vector<unsi
   137             else if (opcode2 == OP_SMALLDATA)
   138             {
   139                 // small pushdata, <= MAX_OP_RETURN_RELAY bytes
   140-                if (vch1.size() > MAX_OP_RETURN_RELAY)
   141+                if (vch1.size() > GetArg("-datacarriersize", MAX_OP_RETURN_RELAY))
   

   ---

   ---

   

   dexX7 commented at 4:36 pm on October 12, 2014:

   I’d seperate user input GetArg("-datacarriersize", ...) from actual logic.

   ---

   

   laanwj commented at 9:43 am on October 14, 2014:

   Yes I think I mentioned this before to @luke-jr in another pull for another issue. Re-parsing the argument every time this function runs is not a good idea, it should only be done once in AppInit2 or so.

   ---

   

   luke-jr commented at 7:58 pm on October 14, 2014:

   We’re already re-parsing -datacarrier every time too. CNodePolicy would be moving these to AppInit2 anyway.
6. 
   jgarzik commented at 2:57 pm on October 13, 2014: contributor

   PR #5075 updates the logic to default to 80 bytes.
7. 
   TheBlueMatt commented at 7:45 pm on October 13, 2014: member

   @jgarzik Making it an option, sure…changing the default…probably should be discussed on the ML.
8. Enable customising node policy for datacarrier data size with a -datacarriersize option 2aa632921e
9. luke-jr force-pushed on Oct 27, 2014
10. 
    laanwj commented at 10:50 am on October 27, 2014: member

    utACK
11. 
    TheBlueMatt commented at 8:32 pm on October 28, 2014: member

     0-----BEGIN PGP SIGNED MESSAGE-----
     1Hash: SHA1
     2
     3utACK commithash 2aa632921efd861a7c9968e8faf6c73cb3d62c4a
     4-----BEGIN PGP SIGNATURE-----
     5Version: GnuPG v2
     6
     7iQIcBAEBAgAGBQJUT/1TAAoJEIm7uGY+LmXObkUQAICuCobiXOYEEd7mMCMB5hKe
     8tlsOgWq7Hi7aZZZH3e0YieLL2XkKExSjKmDrqeOeo/szuPjlLmRsukSDS/fXMzHW
     9/27L5JY5fJdMNLEECm+hV1sm9pHAkFzSDfHUHJAyajEvmQbZNi5Hs6D8Qrk6gbZq
    10539QqJZCxLc6tTHU2Wl9qmZ/6REIuKrOKxos9Qg+vANn8UQbtafCdX65JmlqG/cq
    113MWU/4Yyk66qxO/X9WlcWyYmdYZTgpa9H71y9GP5wtJtXWeC7dRAZY7v5V5+Qr80
    12jaiJEKlTRmq87fzNby5oYqI8dXWYIDIPoxZfHa9CPNsa/wBKkAIb1cghognVrlju
    13jJjxIOIxFff33Pze/PnZlR6Y0+MXN6qfgMqGO7W9Ripkj9CXc0DzdQ6LJdo8i2hN
    14JdfJ8+mbflQmfrJ8ycNubB/nkfxkSA/v/3kU4vtpnk8wga9yY7N8t6kJfZVTNy3a
    159ew6564XnwAgONXe3UW8zXCEImfRUjzmsPrYahHUis3Klb1PFImf2rw8fF85yZJK
    16AaslG156zp85DKeM9wRXXwKxo+VtnYupclvyo/qUmo0r7L5oyaBur/1BqIsnBAyW
    17BhWbkeW4SfEa6pGDGg3SvDEXEgctjS4iqfdHfAyxH5BXPQ4mAgSpwPxYa1DEzoSJ
    182MKxoQTUxRO5gIPqNj60
    19=j96Y
    20-----END PGP SIGNATURE-----
    

12. laanwj merged this on Oct 31, 2014
13. laanwj closed this on Oct 31, 2014

    ---

14. laanwj referenced this in commit 96012e83f1 on Oct 31, 2014
15. luke-jr deleted the branch on Jan 1, 2015
16. MarcoFalke locked this on Sep 8, 2021

Contributors
luke-jr TheBlueMatt dexX7 laanwj jgarzik